Skip to content

Remove redundant generic argument from Aggregator #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cijothomas merged 1 commit into from
Nov 3, 2024
Merged

Remove redundant generic argument from Aggregator #2269

cijothomas merged 1 commit into from
Nov 3, 2024

Conversation

@fraillt
Copy link
Contributor

@fraillt fraillt commented Nov 3, 2024 •
edited
Loading

Basically remove reduntant code (it was introduced in initial revision, but during review process interface changes, so it left here by accident), and simplify Aggregator trait.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@fraillt fraillt requested a review from a team as a code owner November 3, 2024 10:20
@codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (fcd7cae) to head (d89e4f9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2269   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        121     121           
  Lines      20981   20981           
=====================================
  Hits       16673   16673           
  Misses      4308    4308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fraillt fraillt mentioned this pull request Nov 3, 2024
Merged
4 tasks
@cijothomas cijothomas merged commit 16f80c2 into open-telemetry:main Nov 3, 2024
24 of 25 checks passed
@fraillt fraillt deleted the remove-redudant-argument-from-aggregator-trait branch November 7, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utpilla utpilla utpilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fraillt @utpilla @cijothomas